The tests used for testing the Majic Ansible Roles have been created quite some time ago, and there is a number of improvements that could be made to them to improve reliability and reduce the duplication in a number of places.

The following should be done:

• All roles
  • Avoid potential shell injection by using host.run parameter passing for parametrised strings (instead of using the % operator directly).
  • Clean-up the [ANSIBLEXXXX] QA suppression statements to use the noqa syntax which is limited to a single check being disabled instead of disabling all linting checks on a task.
  • Clean-up the names for [ANSIBLEXXXX] QA suppression statements to include only the number. This is a chance in format of linting issues.
  • Switch to using the nmap script ssl-enum-ciphers for testing the available TLS ciphers and protocol information in all tests where possible.
• bootstrap role
  • Deduplicate tests for ansible_key.
• mail_server role
  • Deduplicate tests related to TLS files and their content.
• php_website role
  • Parametrize TLS file checks for the test_nginx_tls_files test similar to the in the wsgi_website role.
• preseed role
  • Deduplicate tests for ansible_key and preseed_directory if possible.
• Determine if any other roles are applicable for similar type of improvements, and apply the improvements to them as well.