At the moment Majic Ansible Roles relies in a couple of places (bootstrap and preseed role) on using optional parameters whose values relies on looking up files in either the home directory or Ansible inventory directory.

Problems with this are:

• In some cases the Ansible inventory directory (inventory_dir variable) may not be set-up in expected way, either because it's put in some temporary location, or maybe a dynamic inventory is used.
• Looking up things in the home directory may accidentally end-up picking-up wrong values - because users could organise their home directory structure in different manner, they may want to rely in different private keys being than the ones from default path etc.
• Some tests end-up looking rather strange due to these two facts (and also more fragile in case Molecule changes handling of the inventory files).

To resolve this, it would be best to instead make such parameters mandatory. While this does mean an extra thing to configure, it also makes the deployment more explicit and clear.

The following should be done:

• Update the bootstrap role.
  • Make the ansible_key parameter mandatory.
• Update the preseed role
  • Make the ansible_key parameter mandatory.
  • Make the preseed_directory parameter mandatory.
• Determine if there are any other spots in the roles that could benefit from a similar change.
• Update role reference documentation.
• Update usage instructions.
• Update test site configuration.