Majic Projects
Majic Ansible Roles
Go to the previous open issue
Go to the previous issue (open or closed)
star_faded.png
Please log in to bookmark issues
icon_project.png Majic Ansible Roles / Open Task MAR-228 Deduplicate and parametrise tests
Go to the next issue (open or closed)
Go to the next open issue
Issue basics
  • Type of issue
    Task
  • Category
    Tests
  • Targetted for
    Not determined
  • Status
    New
  • Progress
  • Priority
    Not determined
User pain
  • Type of bug
    Not triaged
  • Likelihood
    Not triaged
  • Effect
    Not triaged
Affected by this issue (0)
There are no items
People involved
Times and dates
  • Posted at
  • Last updated
  • Estimated time
    2 hours
  • Time spent
    No time spent
    Click here to see time logged against this issue
Issue details
Attachments (0)
There is nothing attached to this issue
Duplicate issues (0)
This issue does not have any duplicates
Description

There could be a number of duplicate tests (code-wise) or tests that depend on iterating over a loop throughout the roles. It would be beneficial to improve the test code by using more parameterisation instead (pytest.mark.parametrize).

The following should be done:

  • Analyse currently implemented tests for all roles, identifying which code could be:
    • Deduplicated.
    • Parametrised.
    • Improved to use fixtures instead of unwieldy values within tests (for things like cipher lists etc).
  • Deduplicate/parametrise tests where possible.
  • Make sure that test coverage has not dropped, and that all tests are still passing.
  • Update role reference documentation.
  • Update usage instructions.
  • Update release notes.
Todos (0 / 0)
There are no comments