Majic Projects
Majic Ansible Roles
Go to the previous open issue
Go to the previous issue (open or closed)
star_faded.png
Please log in to bookmark issues
icon_project.png Majic Ansible Roles / Closed Enhancement MAR-194 Allow only IPv4 and IPv6 addresses for maintenance allowed hosts in common role
Go to the next issue (open or closed)
Go to the next open issue
There are no more issues in that direction.
This issue has been closed with status "Closed" and resolution "RESOLVED".
Issue basics
  • Type of issue
    Enhancement
  • Category
    User interface
  • Targetted for
    8.0.0
  • Status
    Closed
  • Progress
  • Priority
    Normal
User pain
  • Type of bug
    Not triaged
  • Likelihood
    Not triaged
  • Effect
    Not triaged
Affected by this issue (0)
There are no items
People involved
Times and dates
  • Posted at
  • Last updated
  • Estimated time
    2 hours
  • Time spent
    8 hours
    Click here to see time logged against this issue
Issue details
  • Resolution
    RESOLVED
Attachments (0)
There is nothing attached to this issue
Duplicate issues (0)
This issue does not have any duplicates
Description

The common role has the ability to put the managed machine into a maintenance mode in which case incoming connections are allowed only from a specific list of user-provided hosts. The list of allowed hosts is controlled via the maintenance_allowed_hosts parameter.

While a very useful feature during upgrades, the implementation is tied in to resolvable names, and in case the user passes-in a list of IP addresses, the resulting firewall will not get correctly set-up for the IPv6. The use of resolvable names can also lead to ferm failing to start because it cannot resolve the names until the network is fully up and it can connect to the DNS servers.

To simplify the implementation, and make it more unambiguous, only IPv4 and IPv6 addresses should be allowed.

The following should be done:

  • Update the common role.
    • Rename the parameter to maintenance_allowed_sources.
    • Allow only IPv4/IPv6 address to be passed into the parameter.
    • Non-IPv4 or IPv6 addresses should result in an error.
  • Update the role reference documentation.
  • Update usage instructions
  • Update release notes.
Todos (0 / 0)
There are no comments