Majic Projects
Majic Ansible Roles
Go to the previous open issue
Go to the previous issue (open or closed)
star_faded.png
Please log in to bookmark issues
icon_project.png Majic Ansible Roles / Closed Feature request MAR-141 Improve handling of pip requirements check virtual environment
action_vote_minus_faded.png
0
Votes
action_vote_plus_faded.png
Go to the next issue (open or closed)
Go to the next open issue
There are no more issues in that direction.
This issue has been closed with status "Closed" and resolution "RESOLVED".
Issue basics
  • Type of issue
    Feature request
  • Category
    Not determined
  • Targetted for
    3.1.0
  • Status
    Closed
  • Progress
  • Priority
    Not determined
User pain
  • Type of bug
    Not triaged
  • Likelihood
    Not triaged
  • Effect
    Not triaged
Affected by this issue (0)
There are no items
People involved
Times and dates
  • Posted at
  • Last updated
  • Estimated time
    4 hours
  • Time spent
    2 hours
    Click here to see time logged against this issue
Issue details
  • Resolution
    RESOLVED
Attachments (0)
There is nothing attached to this issue
Duplicate issues (0)
This issue does not have any duplicates
Description

The current handling of Python virtual environment used for pip requirements checks in the common role is not optimal. There is a number of issues that cause intermittent failures. For example:

  • Outdated setuptools or pip will prevent the tool from working.
  • There is no guarantee around what version of setuptools or pip is installed at any time.
  • Updating pip/setuptools is not possible.
  • Initial syncing of environment is carried out by installing up-to-date version of pip-tools, and this could end up in failure due to incompatibilities listed above.

To make this functionality work more reliably, it would be necessary to change the way all the relevant packages are installed.

The following should be done:

  • Update the common role.
    • Include all packages, including pip and setuptools in requirements.in and requirements.txt.
    • Install the necessary packages with the pip install -r requirements.txt initially, and then simply resort to invoking pip-sync as well to clean-up stale unused packages.
  • Update the pip_check_requirements_upgrades.sh script to use to invoke pip-compile with --allow-unsafe option.
  • Update role documentation with new parameter values, and notify of change in the use of --allow-unsafe option.
  • Update role documentation.
Todos (0 / 0)
There are no comments