Majic Projects
previous_open_issue.png
Go to the previous open issue
previous_issue.png
Go to the previous issue (open or closed)
star_faded.png
Please log in to bookmark issues
bug_report_small.png
Closed Bug report MAR-102 False positives reported by pip_check_requirements_upgrades.sh script
next_issue.png
Go to the next issue (open or closed)
next_open_issue.png
Go to the next open issue
icon_info.png This issue has been closed with status "Closed" and resolution "RESOLVED".
Issue basics
  • Type of issue
    Bug report
  • Category
    General
  • Targetted for
    1.6.0
  • Status
    Closed
  • Progress
  • Priority
    Not determined
User pain
  • Type of bug
    Not triaged
  • Likelihood
    Not triaged
  • Effect
    Not triaged
Affected by this issue (1)
People involved
Times and dates
  • Posted at
  • Last updated
  • Estimated time
    1 hour
  • Time spent
    1 hour
    Click here to see time logged against this issue
Issue details
  • Resolution
    RESOLVED
  • Reproducability
    Often
  • Severity
    Normal
Attachments (0)
There is nothing attached to this issue
Duplicate issues (0)
This issue does not have any duplicates
Description

Depending on the packages that are part of pip requirements and input files, pip_check_requirements_upgrades.sh may end-up reporting false positives. This happens due to the fact that script does not perform sorting on both input files (current and newly generated requirements files).

An additional problem is that when calculating the new requirements files, it is necessary to call the tool with --upgrade option - otherwise proper upgrade checks may not be done.

Steps to reproduce this issue

Reproduction steps:

  1. Set-up and activate virtual environment with pip-tools installed

  2. Create requirements.in with the following content:

    django~=1.8.0
    django-auth-ldap
    django-apptemplates
    MySQL-python
    wiki
    pygments
    
  3. Generate requirements.txt:

    pip-compile requirements.in
    
  4. Run pip_check_requirements_upgrades.sh against the generated files.

Expected results:

  1. Script reports that no upgrades are available.

Actual results:

  1. Script reports that upgrades are available, showing a diff where position of the django entry has changed.
Comments ()
There are no comments
History